Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: qBittorrent.qBittorrent version 4.3.9 #34731

Closed
wants to merge 1 commit into from

Conversation

gregoryka
Copy link
Contributor

@gregoryka gregoryka commented Nov 12, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Nov 12, 2021
@ghost
Copy link

ghost commented Nov 12, 2021

Hello @gregoryka,
The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made.

@ghost ghost added Needs-Author-Feedback This needs a response from the author. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 12, 2021
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagged as PUA or Malware: #34731 (comment)

At the moment, there's not much you can do to solve this.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 13, 2021
@gregoryka
Copy link
Contributor Author

Kind of weird considering VirusTotal says the files are ok
x64 x86
Would maybe be nice to know which one flagged, but nothing much I can do, unfortunately.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 13, 2021
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of weird considering VirusTotal says the files are ok x64 x86 Would maybe be nice to know which one flagged, but nothing much I can do, unfortunately.

I wrote about VirusTotal a while ago, but the pipelines doesn't seem to utilize it according to #373 (comment). What the pipelines does right now is do static analysis, and dynamic analysis (run on various anti-virus software) on the installers in the package.

You can reproduce the VirusTotal situation above, by uploading an installer which has a very low download counts (i.e. internal builds for Microsoft Teams) to VirusTotal, and in that report's details, you will see that First Submission is from 2021-11-13 (today) instead of 6+ months ago.

Your report for both of those URLs doesn't show the statistics for Microsoft Defender as it seems to be a known issue for a lot of people using first-party anti-virus software from Microsoft: qbittorrent/qBittorrent#15674, qbittorrent/qBittorrent#15667, qbittorrent/qBittorrent#15134.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 13, 2021
@gregoryka gregoryka closed this Nov 13, 2021
@gregoryka gregoryka deleted the qBittorrent4.3.9 branch November 25, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants