Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VeraCrypt #3978

Closed
wants to merge 1 commit into from
Closed

VeraCrypt #3978

wants to merge 1 commit into from

Conversation

danthe1st
Copy link
Contributor

@danthe1st danthe1st commented Oct 6, 2020 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
    There is Add VeraCrypt 1.24-Update6 #846 but the YAML file is anvalid and it has been closed for inactivity.
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

This PR adds the package VeraCrypt.

Silent flags are not supported by the installer as stated in this issue.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost
Copy link

ghost commented Oct 6, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Oct 6, 2020
@ghost ghost assigned KevinLaMS Oct 6, 2020
@ghost
Copy link

ghost commented Oct 6, 2020

This submission has moved to manual review.

@ghost ghost assigned danthe1st Oct 6, 2020
@ghost
Copy link

ghost commented Oct 6, 2020

Greetings danthe1st
During installation testing, this application failed to install with out user input. Did you forget to add Silent or SilentWithProgress switches?

Please investigate a fix and resubmit the Pull Request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Oct 6, 2020
@KevinLaMS
Copy link
Contributor

Validation-Unattend-Failed

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Oct 13, 2020
@ghost
Copy link

ghost commented Oct 13, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@danthe1st
Copy link
Contributor Author

There is no option for an installation without opening an installation window as described here.

@ghost ghost added Needs: Attention and removed Needs: author feedback No-Recent-Activity No activity has occurred on this work item for seven days. labels Oct 14, 2020
@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs: Attention labels Oct 29, 2020
@denelon
Copy link
Contributor

denelon commented May 4, 2021

microsoft/winget-cli#910

We need to give users the ability to filter out packages that require interactive install.

@mddtest mddtest mentioned this pull request Jun 20, 2021
Closed
@lionelberton
Copy link

Latest veracrypt version (1.25.4) now support silent install.
use switch "/qn ACCEPTLICENSE=YES" on msiexec command line to do silent install.
use switch "/norestart" to avoid rebooting.

So you should now be able to push this package forward, at last.
veracrypt/VeraCrypt#447

@danthe1st
Copy link
Contributor Author

closing this in favour of #39863

@danthe1st danthe1st closed this Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Hello @danthe1st,
This package appears to require user interaction to complete. Please check to see if this package can be installed unattended, and modify the manifest.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 4, 2022
@danthe1st danthe1st mentioned this pull request Jan 4, 2022
Closed
5 tasks
@denelon denelon added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jul 14, 2022
@ghost
Copy link

ghost commented Jul 14, 2022

Hello @danthe1st,
This package appears to require user interaction to complete. Please check to see if this package can be installed unattended, and modify the manifest.

Template: msftbot/validationError/installation/unattended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KevinLaMS KevinLaMS

@danthe1st danthe1st

Labels
Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danthe1st @wingetbot @KevinLaMS @denelon @lionelberton