Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDPlayer.LDPlayer version 9.0.36 #95662

Conversation

TaQuangKhoi
Copy link

@TaQuangKhoi TaQuangKhoi commented Feb 5, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TaQuangKhoi
Copy link
Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Feb 5, 2023
@stephengillie stephengillie self-assigned this Feb 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Feb 8, 2023
@stephengillie
Copy link
Collaborator

Hi @TaQuangKhoi,

Does the installer have an unattended mode? Currently the installer requires user interaction.
image

@stephengillie stephengillie added Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. and removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. labels Feb 8, 2023
@stephengillie stephengillie removed their assignment Feb 8, 2023
…en-US.yaml

Co-authored-by: Stephen Gillie <114952565+stephengillie@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Feb 9, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Feb 9, 2023
@TaQuangKhoi
Copy link
Author

Hi @stephengillie ,

I think that the installer doesn't have unattended mode.

Is it required to have this mode to commit to repo?

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Feb 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @wingetbot,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@stephengillie
Copy link
Collaborator

Hi @stephengillie ,

I think that the installer doesn't have unattended mode.

Is it required to have this mode to commit to repo?

Hi @TaQuangKhoi,

Unfortunately, installers must have a fully attended mode to be accepted into the Winget public manifest at this time. This installer might be supported with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback This needs a response from the author. Retry-1 flag to indicate retried Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants