Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BakkesMod.BakkesMod version 31 #98387

Conversation

CanePlayz
Copy link
Contributor

@CanePlayz CanePlayz commented Mar 3, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CanePlayz
Copy link
Contributor Author

@microsoft-github-policy-service agree

@CanePlayz
Copy link
Contributor Author

CanePlayz commented Mar 3, 2023

I have to note that I've heard but I'm not sure that only applications supporting silent installations would be supported. In that case, BakkesMod would be a more complicated case. What I've submitted here is the Setup.exe which installs the BakkesMod Injector and the current underlying BakkesMod version for you.

However, if only programs supporting silent installs are supported, we could instead make it so that the .exe from here is downloaded. That just downloads the injector and then lets you install the underlying version from inside the injector via an update.

Edit: I think the second option isn't that good since the .exe that you later need to open the program is what you download and it doesn't get put into ProgramData or anything similar.

@CanePlayz
Copy link
Contributor Author

Uhm that's not normal, is it?

image

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Mar 4, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @CanePlayz,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made.

Template: msftbot/validationError/installers/binaryValidation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 4, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. Needs-Author-Feedback This needs a response from the author. labels Mar 4, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Mar 4, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @CanePlayz,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made.

Template: msftbot/validationError/installers/binaryValidation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 4, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. Needs-Author-Feedback This needs a response from the author. labels Mar 4, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Mar 4, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @CanePlayz,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made.

Template: msftbot/validationError/installers/binaryValidation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 4, 2023
@CanePlayz
Copy link
Contributor Author

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 4, 2023
@CanePlayz
Copy link
Contributor Author

Unfortunately, MS wasn't able to reproduce any detection: https://www.microsoft.com/en-us/wdsi/submission/7d4fdf5c-a7d6-4115-99e3-b5faee7b108c What am I supposed to do now?

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 9, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CanePlayz
Copy link
Contributor Author

CanePlayz commented Mar 9, 2023

The team behind BakkesMod has decided they do not want their software to be featured on winget, and I will respect that of course. I will leave this PR open so you can keep on testing the pipelines if you want to, feel free to close the PR any time though.

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Mar 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @CanePlayz,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made.

Template: msftbot/validationError/installers/binaryValidation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 9, 2023
@stephengillie
Copy link
Collaborator

/azp run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. Needs-Author-Feedback This needs a response from the author. labels Mar 10, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Mar 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @CanePlayz,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made.

Template: msftbot/validationError/installers/binaryValidation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 10, 2023
@stephengillie
Copy link
Collaborator

This is an Inno installer and the switch /? gives its installer switches:
image

But even with /VERYSILENT /SUPPRESSMSGBOXES /FORCECLOSEAPPLICATIONS it still pops up with the box. So it doesn't appear to have an unattended mode. Blocked by:

@stephengillie stephengillie added Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. and removed Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. labels Mar 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @CanePlayz,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@CanePlayz
Copy link
Contributor Author

This is an Inno installer and the switch /? gives its installer switches: image

But even with /VERYSILENT /SUPPRESSMSGBOXES /FORCECLOSEAPPLICATIONS it still pops up with the box. So it doesn't appear to have an unattended mode. Blocked by:

Thanks for your investigations, but as I mentioned above, unfortunately, the devs don't want their software on winget...

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 10, 2023
@stephengillie
Copy link
Collaborator

The team behind BakkesMod has decided they do not want their software to be featured on winget, and I will respect that of course. I will leave this PR open so you can keep on testing the pipelines if you want to, feel free to close the PR any time though.

Thanks for letting us know.

@CanePlayz CanePlayz deleted the autogenerated/BakkesMod.BakkesMod/80ea0199-7bfb-43f8-ad11-dd6c2f83e759 branch March 13, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants