-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BakkesMod.BakkesMod version 31 #98387
BakkesMod.BakkesMod version 31 #98387
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@microsoft-github-policy-service agree |
I have to note that I've heard but I'm not sure that only applications supporting silent installations would be supported. In that case, BakkesMod would be a more complicated case. What I've submitted here is the Setup.exe which installs the BakkesMod Injector and the current underlying BakkesMod version for you. However, if only programs supporting silent installs are supported, we could instead make it so that the .exe from here is downloaded. That just downloads the injector and then lets you install the underlying version from inside the injector via an update. Edit: I think the second option isn't that good since the .exe that you later need to open the program is what you download and it doesn't get put into ProgramData or anything similar. |
Hello @CanePlayz, The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made. Template: msftbot/validationError/installers/binaryValidation |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @CanePlayz, The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made. Template: msftbot/validationError/installers/binaryValidation |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @CanePlayz, The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made. Template: msftbot/validationError/installers/binaryValidation |
Unfortunately, MS wasn't able to reproduce any detection: https://www.microsoft.com/en-us/wdsi/submission/7d4fdf5c-a7d6-4115-99e3-b5faee7b108c What am I supposed to do now? |
Azure Pipelines successfully started running 1 pipeline(s). |
The team behind BakkesMod has decided they do not want their software to be featured on winget, and I will respect that of course. I will leave this PR open so you can keep on testing the pipelines if you want to, feel free to close the PR any time though. |
Hello @CanePlayz, The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made. Template: msftbot/validationError/installers/binaryValidation |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @CanePlayz, The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made. Template: msftbot/validationError/installers/binaryValidation |
Hello @CanePlayz, During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches? This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest. Please investigate a fix and resubmit the Pull Request. You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress. Template: msftbot/validationError/installation/unattended |
Thanks for letting us know. |
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow