Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roblox.Roblox version 1.6.0.24449 #99427

Closed
wants to merge 2 commits into from
Closed

Roblox.Roblox version 1.6.0.24449 #99427

wants to merge 2 commits into from

Conversation

UtilisateurDeGithu
Copy link
Contributor

@UtilisateurDeGithu UtilisateurDeGithu commented Mar 14, 2023 •
edited by microsoft-github-policy-service bot
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Mar 14, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @UtilisateurDeGithu,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 14, 2023
@stephengillie
Copy link
Collaborator

Hi @UtilisateurDeGithu,

Unfortunately, the architecture of the Roblox CDN, with different per-CDN hashes, makes it a poor fit for installation through the WinGet package manager.

@UtilisateurDeGithu
Copy link
Contributor Author

UtilisateurDeGithu commented Mar 14, 2023 •
edited
Loading

Hi, @stephengillie,

Do you means that Roblox client is considered as incompatible with winget due to how this installer work?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 14, 2023
@stephengillie
Copy link
Collaborator

Do you means that Roblox client is considered as incompatible with winget due to how this installer work?

Apologies, apparently this isn't an issue anymore. But the installer isn't unattended:
image

Is there an installer switch to clear this OK box? If one is found, then this will pass that validation step.

@UtilisateurDeGithu
Copy link
Contributor Author

Do you means that Roblox client is considered as incompatible with winget due to how this installer work?

Apologies, apparently this isn't an issue anymore. But the installer isn't unattended: image

Is there an installer switch to clear this OK box? If one is found, then this will pass that validation step.

I'm currently searching if there is a launch argument, the problem is there is no documentation and help menu.

@UtilisateurDeGithu
Copy link
Contributor Author

There is no silent/no interactivity switch to skip the "successfully installed" dialog box, that make winget waiting for the user a manual interaction with the installer.

@stephengillie
Copy link
Collaborator

This might be supported under:

@UtilisateurDeGithu UtilisateurDeGithu marked this pull request as draft March 18, 2023 10:47
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Mar 18, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Mar 18, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @UtilisateurDeGithu,

I am sorry to report that the Sha256 Hash does not match the installer. This may be caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

Template: msftbot/validationError/installers/hashMismatch

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 18, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Author-Feedback This needs a response from the author. labels Mar 18, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Mar 18, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @UtilisateurDeGithu,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 18, 2023
@UtilisateurDeGithu UtilisateurDeGithu closed this by deleting the head repository Apr 7, 2023
@russellbanks russellbanks mentioned this pull request May 15, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@UtilisateurDeGithu UtilisateurDeGithu

Labels
Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@UtilisateurDeGithu @wingetbot @stephengillie @yao-msft @ryfu-msft