Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use z3 version 4.9.1 #36

Closed
NikolajBjorner opened this issue Jul 6, 2022 · 9 comments
Closed

Use z3 version 4.9.1 #36

NikolajBjorner opened this issue Jul 6, 2022 · 9 comments
Assignees

Comments

@NikolajBjorner
Copy link
Collaborator

There is a new release of z3 out today.
It doesn't seem to get picked up by the build.
It has some npm version dependencies as well that have changed.
With this release we should be able to remove some of the no-build tags.

@NikolajBjorner
Copy link
Collaborator Author

weird, package.json says I am wrong

@rlisahuang
Copy link
Contributor

Let me look into it

@NikolajBjorner
Copy link
Collaborator Author

Note, this may be blocking at the moment
Z3Prover/z3#6139

@rlisahuang
Copy link
Contributor

So we roll back to 4.8.7 until notified?

@rlisahuang
Copy link
Contributor

I actually don't think that it is a good idea to automate updating z3. A broken / incompatible version can break our code. For any dependency including z3-solver, we would need to test if a newer version is compatible with our codebase before upgrading it.

@rlisahuang
Copy link
Contributor

The update is simple as well. Running yarn install <package_name> locally / in codespaces (not through github workflows) will update package.json and yarn.lock accordingly, which will be later picked up by github actions.

@rlisahuang
Copy link
Contributor

I just enforced z3-solver 4.8.17 on main. Ping me when the update is ready and I'll test and update manually.

@NikolajBjorner
Copy link
Collaborator Author

4.9.1 is out now, npmjs should be updated soon. Let's see if this one works.

@NikolajBjorner NikolajBjorner changed the title Use z3 version 4.9.0 Use z3 version 4.9.1 Jul 7, 2022
@rlisahuang
Copy link
Contributor

4.9.1 merged to main now. I added an ignore-errors flag to the code snippet

(simplify (_char 100000000))

per your request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants