Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix js distributable #6139

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jul 6, 2022

#6048 reorganized the files in the JS api which made the published artifact not work (so the just-published 4.9.0 doesn't work at all; attempting to import it throws). This fixes that. It also marks the package as usable on node 18, due to the inclusion of #6136.

@NikolajBjorner NikolajBjorner merged commit 0d41695 into Z3Prover:master Jul 6, 2022
@NikolajBjorner
Copy link
Contributor

thanks for looking into this.
Let me know if I need to crank up 4.9.1 today or we can revert the npmjs dist.

@bakkot bakkot deleted the engine-restriction branch July 6, 2022 18:03
@bakkot
Copy link
Contributor Author

bakkot commented Jul 6, 2022

It's possible to npm unpublish the new version, so that only the old version exists, but unfortunately you can't just then re-publish the fixed thing - npm won't let you reuse a version number even after unpublishing. It will require a new version to get something which works and also is current.

@NikolajBjorner
Copy link
Contributor

so I will then roll a 4.9.1 now

@bakkot
Copy link
Contributor Author

bakkot commented Jul 6, 2022

4.9.1 looks like it works! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants