Async->Sync revert

[ramsessanchez]

Begin Work for Async -> Sync Revert
fixes microsoft/kiota-java#175
Needs: tests still need to be fixed

[baywet]

@ramsessanchez: @andrueastman and I had a quick chat the other day. I think this is what we'll end up doing:

• get rid of service exception, and replace it by api exception (already done)
• throw directly the API exceptions, do not wrap them. Depending on whether we land on a checked or unchecked exception (kiota java discussion), this will need to be declared in methods prototype
• for client exceptions, use native exceptions where it makes sense (like IllegalArgumentException, InterruptedException, etc...) and throw them.
• if we still need a client exception, keep that class, do not inherit from Api exception, throw it without wrapping it, (declare in prototypes). But it should only be used for client behaviour issues (nothing related to the service side), and when it can't be replaced by native exceptions.

Hopefully this clarifies things, and I think you have a connect scheduled with Andrew today anyway.

[baywet]

Thanks for making the changes

[ramsessanchez]

Once Kiota-Java is bumped to 0.9.0 this should be good to go

[sonarcloud]

SonarCloud Quality Gate failed.   

1 Bug
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

0.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[baywet]

@ramsessanchez can you have a look at the latest sonarcloud analysis please? There seems to be a mismatch between the method metadata and its behaviour (nullability)