-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async->Sync revert #1286
Async->Sync revert #1286
Conversation
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@ramsessanchez: @andrueastman and I had a quick chat the other day. I think this is what we'll end up doing:
Hopefully this clarifies things, and I think you have a connect scheduled with Andrew today anyway. |
ff02b4d
to
a485786
Compare
src/main/java/com/microsoft/graph/content/BatchRequestContent.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/graph/tasks/LargeFileUploadTask.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes
Once Kiota-Java is bumped to 0.9.0 this should be good to go |
SonarCloud Quality Gate failed. 1 Bug 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@ramsessanchez can you have a look at the latest sonarcloud analysis please? There seems to be a mismatch between the method metadata and its behaviour (nullability) |
Begin Work for Async -> Sync Revert
fixes microsoft/kiota-java#175
Needs: tests still need to be fixed