Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricts escaping of special characters to path segments only when using Invoke-MgGraphRequest and bumps Azure.Identity.Broker Library #2690

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

timayabi2020
Copy link
Contributor

Fixes #1947 and Azure.Identity.Broker package conflict due to bumping of Azure Identity here

Changes proposed in this pull request

  • Restricted escaping/URL encoding of special characters in path segments only. Uri with system query options should not URL encoded values.

Uri with OData system query options
image

Uri with special characters in path segments
image

  • Updated Azure.Identity.Broker due to interactive browser errors (Method 'get_UseDefaultBrokerAccount' in type 'Azure.Identity.Broker.InteractiveBrowserCredentialBrokerOptions' from assembly 'Azure.Identity.Broker, Version=1.0.0.0, Culture=neutral, PublicKeyToken=92742159e12e44c8' does not have an implementation) as a result of bumping the Azure.Identity. The version bump is based on the library documentation here

@timayabi2020 timayabi2020 requested a review from a team as a code owner April 18, 2024 14:03
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@timayabi2020 timayabi2020 merged commit 05b939d into dev Apr 19, 2024
2 of 3 checks passed
@timayabi2020 timayabi2020 deleted the fix_special_characters_invokemgraph branch April 19, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoke-MgGraphRequest can't handle URI with #
2 participants