Remove deadlock - use single mutex in PersistenceManager #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fh-ms
requested changes
Sep 15, 2021
persistence/persistence/src/main/java/one/microstream/persistence/types/PersistenceManager.java
Show resolved
Hide resolved
zdenek-jonas
force-pushed
the
remove_deadlock
branch
from
40d81b1 to
bcce2b3
Compare
fh-ms
approved these changes
Sep 15, 2021
fh-ms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the same resources are used as lock in both methods, so deadlock may occur. Therefore replaced by only one mutex. Tested, the most common deadlock is removed. I have not shown any performance impact even after long tests.