Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middy-env to 3rd party middleware list #352

Merged
merged 3 commits into from
Jun 23, 2019
Merged

Add middy-env to 3rd party middleware list #352

merged 3 commits into from
Jun 23, 2019

Conversation

chrisandrews7
Copy link
Contributor

Adding middy-env to 3rd party middleware list

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #352   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines         543    543           
  Branches      111    111           
=====================================
  Hits          543    543

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69d858...5e02302. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #352   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines         545    543    -2     
  Branches      112    111    -1     
=====================================
- Hits          545    543    -2
Impacted Files Coverage Δ
src/middlewares/warmup.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41be650...ee157f7. Read the comment docs.

@lmammino
Copy link
Member

Thanks @chrisandrews7, i'll try to get this merged in the next few hours :)

@lmammino lmammino self-requested a review June 23, 2019 17:01
@lmammino lmammino merged commit d7ea2e2 into middyjs:master Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants