The httpResponseSerializer needs to find a serializer for a type by searching all the types
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by searching all the `types`. And all the `opts.serializers` too. [`Array.prototype.find`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find) short circuits on truthy return values of its callback, which means that we only would've ever traversed the array for the first element of `types` since `opts.serializers.map` just returns an array of booleans right? Fix this typo and add a test to cover my use case of wanting to fall back to a default if no preferred serializer is found.
willfarrell
approved these changes
Jul 17, 2020
|
Hey @willfarrell, Got an idea of when this'll go out? I'm about to release something into production and don't really want to have to build & cut my own |
|
Sorry about that. Been working around the clock these days. I'll make time this week to put a release together. expect a v1.1.0 |
|
Thank you very much! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
And all the
opts.serializerstoo.Array.prototype.findshort circuits on truthy return values of its callback, which means that we only would've ever traversed the array for the first element oftypessinceopts.serializers.mapjust returns an array of booleans right?Fix this typo and add a test to cover my use case of wanting to fall back to a default if no preferred serializer is found.
Does this close any currently open issues?
Nothing that I could find from my quick searching. I just needed this for myself right now.
Any relevant logs, error output, etc?
N/A
Any other comments?
None.
Where has this been tested?
Node.js Versions: 12
Middy Versions: 1
AWS SDK Versions: N/A
Todo list