-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator accepting plugins #552
Conversation
Including pckg-lock
Interesting approach, I was thinking something different. I like this better, cleaner. Thinking out loud here: Maybe What do you think? |
Thanks for the feedback. And yes, makes sense. So to task it out if I understood correctly:
In case the user prefers to apply one of the out-of-the-box plugins for further customization I guess we should prioritize that, which we could as we would be defaulting the plugins similar to options 👍 |
Applying plugin system internally
Well @willfarrell, I think we might need to leave BTW, got |
Please let me know if this is OK @willfarrell. |
This change broke a running project. I'm receiving this error:
Is necessary any change or manual library import? |
|
Let me know if I can help @willfarrell. It may be related to the dynamic require, can't see why at the moment. |
@renanwilliam I was able to reproduce your code issue. Are you using |
@willfarrell just additional information, I have added manually as a dependency but keeps throwing the error. Rolling back to ~1.2.0 solves the problem. |
Yes, I'm using with |
Did some testing, and was unsuccessful in finding a solution. Updating the bundle config should have done it (see below). serverless.yml
I'm not a webpack expert, so can't take it any furthur at this time. @renanwilliam if you can open an issue at https://github.com/AnomalyInnovations/serverless-bundle/issues/new, I'd be interested in what the solution is and how we can update our docs to prevent this issue for others. cc @AnomalyInnovations What I can do is update the module to allow the ability to remove all default plugins by passing in |
@willfarrell if you could share a reproducible project to test solutions I can give it a try, have a couple of ideas. Thanks @renanwilliam for reporting this and being patient. |
I was testing on a private repo. Any serverless project w/ serverless-bundle should invoke the issue. |
A 'plugin' array would have been more useful considering Any way to add the |
@ayushsharma82 Please see my response on #698 |
(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)
What does this implement/fix? Explain your changes.
Implements the ability to apply passed plugins to validator
Does this close any currently open issues?
Closes #550
Any relevant logs, error output, etc?
N/A
Any other comments?
N/A
Where has this been tested?
Node.js Versions: 12.16.1
Middy Versions: 1.2.0
AWS SDK Versions: 2.656.0
Todo list
[x] Feature/Fix fully implemented
[x] Added tests
[x] Updated relevant documentation
[x] Updated relevant examples