Fix issue #742 (#745)

* Fix error comparison in SetTA * Add testcase TestParseTA()
miekg · Sep 22, 2018 · 501e858 · 501e858
1 parent 833bf76
commit 501e858
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/scan_rr.go b/scan_rr.go
@@ -1665,9 +1665,9 @@ func setTA(h RR_Header, c chan lex, o, f string) (RR, *ParseError, string) {
 		return nil, &ParseError{f, "bad TA DigestType", l}, ""
 	}
 	rr.DigestType = uint8(i)
-	s, e, c1 := endingToString(c, "bad TA Digest", f)
-	if e != nil {
-		return nil, e.(*ParseError), c1
+	s, err, c1 := endingToString(c, "bad TA Digest", f)
+	if err != nil {
+		return nil, err, c1
 	}
 	rr.Digest = s
 	return rr, nil, c1

diff --git a/scan_test.go b/scan_test.go
@@ -79,3 +79,13 @@ func TestParseZoneInclude(t *testing.T) {
 		}
 	}
 }
+
+func TestParseTA(t *testing.T) {
+	rr, err := NewRR(` Ta 0 0 0`)
+	if err != nil {
+		t.Fatalf("expected no error, but got %s", err)
+	}
+	if rr == nil {
+		t.Fatal(`expected a normal RR, but got nil`)
+	}
+}