Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #41

Merged
merged 5 commits into from
Mar 2, 2024
Merged

Master #41

merged 5 commits into from
Mar 2, 2024

Conversation

hi-im-phillip
Copy link

get public ip method refactor

  • response status diff 200 try another api
  • test status 500 fetch public ip

@mietzen
Copy link
Owner

mietzen commented Mar 2, 2024

Great Idea to have a backup, thank you for your contribution!

@mietzen mietzen merged commit 19f1199 into mietzen:main Mar 2, 2024
15 checks passed
@hi-im-phillip
Copy link
Author

No problem. I added it because the api was down for some reason and could use some backup and clearer message when is down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants