Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to inherit video resolution #13

Closed
pixelchai opened this issue Apr 23, 2020 · 8 comments
Closed

Option to inherit video resolution #13

pixelchai opened this issue Apr 23, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@pixelchai
Copy link

Good work on this project.

Using the CLI, I am concatenating two video files like so

editly first_file.mp4 second_file.mp4 --out output.mp4

The input files are both 1920x1080, but the resulting video file is 640x360

Specifying the width and height in the command works, however, providing an option to automatically detect the lowest common resolution from the input files would be a good enhancement

@mifi
Copy link
Owner

mifi commented Apr 24, 2020

Yea, I default to a width of 640, because with bigger resolutions it tends to take a longer time to process. I wanted the default command line to produce something relatively quickly, and if people want a higher resolution they can just add parameters.

I could find the lowest common resolution, but I'm not sure how to define lowest common, is it width multiplied by height? as in number of total pixels? Then the output aspect ratio will depend on the aspect ratio of the smallest video (in term of n pixels)

@mifi mifi added the enhancement New feature or request label Apr 24, 2020
@pixelchai
Copy link
Author

Actually, maybe you could just inherit the resolution of the first video provided

@mifi
Copy link
Owner

mifi commented Apr 28, 2020

Yes, but I think most people don't really need full 4K resolution output, and if they do, it's easy to just specify it. I find it more important that it generates a video relatively quickly for first time users

@chapmanjacobd
Copy link
Contributor

chapmanjacobd commented Apr 28, 2020

maybe one solution could be that we put --fast in all the examples so that it is fast for first time users but we could default to a compromise resolution like 720p / resolution of first input video

@mifi
Copy link
Owner

mifi commented Apr 28, 2020

That's a good idea. I will do that

@mifi mifi closed this as completed in c6e20cc Apr 28, 2020
@gunar
Copy link

gunar commented Sep 21, 2020

I wish width and height would still override resolution inheritance, even with fast: true, because otherwise I have no way to test that my elements are correctly positioned, other than running it with fast: false—which defeats the purpose of having a preview option. FYI I'm cropping a vertical video down to a square.

@mifi
Copy link
Owner

mifi commented Sep 24, 2020

Maybe we could instead preserve aspect ratio with fast: true, and make sure the total number of pixels is quite low.

@mifi mifi reopened this Sep 24, 2020
mifi added a commit that referenced this issue Oct 27, 2020
@mifi
Copy link
Owner

mifi commented Oct 27, 2020

Now --fast will keep the aspect ratio, just make the video smaller (62500 pixels)

@mifi mifi closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants