Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffmpeg version check #34

Closed
majidmanzarpour opened this issue Apr 30, 2020 · 6 comments
Closed

Add ffmpeg version check #34

majidmanzarpour opened this issue Apr 30, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@majidmanzarpour
Copy link

I've tried converting my audio file to different formats (mp3 lame, ogg) and I keep getting complaints about AAC:

720x1280 30fps
createFrameSource linear-gradient clip 0 layer 0
createFrameSource title clip 0 layer 1
createFrameSource fill-color clip 1 layer 0
createFrameSource title clip 1 layer 1
  0% [aac @ 0x1dec620] The encoder 'aac' is experimental but experimental codecs are not enabled, add '-strict -2' if you want to use it.
Output ffmpeg caught error Error: write EPIPE
    at afterWriteDispatched (internal/stream_base_commons.js:146:25)
    at writeGeneric (internal/stream_base_commons.js:137:3)
    at Socket._writeGeneric (net.js:698:11)
    at Socket._write (net.js:710:8)
    at doWrite (_stream_writable.js:417:12)
    at writeOrBuffer (_stream_writable.js:401:5)
    at Socket.Writable.write (_stream_writable.js:301:11)
    at /usr/local/lib/node_modules/editly/index.js:406:51
    at new Promise (<anonymous>)
    at module.exports (/usr/local/lib/node_modules/editly/index.js:406:15) {
  errno: 'EPIPE',
  code: 'EPIPE',
  syscall: 'write'
}
Loop failed Error: write EPIPE
    at afterWriteDispatched (internal/stream_base_commons.js:146:25)
    at writeGeneric (internal/stream_base_commons.js:137:3)
    at Socket._writeGeneric (net.js:698:11)
    at Socket._write (net.js:710:8)
    at doWrite (_stream_writable.js:417:12)
    at writeOrBuffer (_stream_writable.js:401:5)
    at Socket.Writable.write (_stream_writable.js:301:11)
    at /usr/local/lib/node_modules/editly/index.js:406:51
    at new Promise (<anonymous>)
    at module.exports (/usr/local/lib/node_modules/editly/index.js:406:15) {
  errno: 'EPIPE',
  code: 'EPIPE',
  syscall: 'write'```
@chapmanjacobd
Copy link
Contributor

@mifi maybe we should automatically print ffmpeg version when we handle an error

@majidmanzarpour
Copy link
Author

@chapmanjacobd ffmpeg version 2.8.15-0ubuntu0.16.04.1 Copyright (c) 2000-2018 the FFmpeg developers built with gcc 5.4.0 (Ubuntu 5.4.0-6ubuntu1~16.04.10) 20160609

@chapmanjacobd
Copy link
Contributor

I don't think that you'll see this error if you update ffmpeg to a more recent version but it would be good if we could handle older versions of ffmpeg correctly @mifi

@majidmanzarpour
Copy link
Author

majidmanzarpour commented Apr 30, 2020

Thanks @chapmanjacobd that worked.

For anyone else running into this issue, I upgraded to ffmpeg 4 on an older version of Ubuntu using these instructions http://ubuntuhandbook.org/index.php/2018/10/install-ffmpeg-4-0-2-ubuntu-18-0416-04/

@mifi
Copy link
Owner

mifi commented May 1, 2020

Ok, thanks. I agree we should add a version check or maybe just include ffmpeg #23, and we can add to Requirements

@mifi mifi reopened this May 1, 2020
@mifi mifi added the enhancement New feature or request label May 1, 2020
@mifi mifi changed the title The encoder 'aac' is experimental but experimental codecs are not enabled Add ffmpeg version check May 17, 2020
mifi added a commit that referenced this issue Oct 29, 2020
@mifi
Copy link
Owner

mifi commented Oct 29, 2020

This is now implemented and will be released in the newest version

@mifi mifi closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants