Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker[-compose] support #96

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Dec 8, 2020

Couldn't get editly working on my local OSX instance, so leaned on docker to get things going.

Added a simple container to persist some state between containers and make it easier to get artefacts out. Final image is quite large (~1GB), but could probably be made smaller. I tried to get it going with alpine linux at first (smaller footprint, likely around 300mb) but had some issues, so just cut my losses and got things working on ubuntu 18.04 first.

Someone might want to take a stab at getting this working on alpine, but I'd recommend it be another PR :)

Quick screenshare showing how this works (small typo, oops): https://recordit.co/SjnT1Oq40l

This will be essential on the way to #93

@patcon
Copy link
Contributor Author

patcon commented Dec 8, 2020

Here's my nonfunctional dockerfile for alpine linux in case anyone else wants to continue with it later: https://gist.github.com/patcon/78f53bf37dc954a4d238ad28f0789b1b

@mifi
Copy link
Owner

mifi commented Dec 8, 2020

Awesome! Thanks

@mifi mifi merged commit 52f643b into mifi:master Dec 8, 2020
@patcon patcon deleted the docker-containerized-cli branch December 8, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants