Push paper-dialog forward. Still WIP. #313
Conversation
…ange. tap="close" -> onTap=(action "close")
…Reverse when transitions work.
|
Updated top comment to reflect the last 4 commits. This branch should now be functional again, but with transitions disabled. |
…mary-colored buttons.
…t naming standard.
… argument naming standard." This reverts commit d056c23.
| classNames: ['md-default-theme'], | ||
| classNameBindings: ['contentOverflow:md-content-overflow', 'fullscreen:md-dialog-fullscreen'], | ||
| classNames: ['md-default-theme' , 'md-transition-in' /* TODO */ ], | ||
| classNameBindings: ['contentOverflow:md-content-overflow', 'dialogComponent.fullscreen:md-dialog-fullscreen'], |
There was a problem hiding this comment.
Can't we get rid of dialogComponent properties by invoking paper-dialog-inner as
?
Since paper-dialog-inner is a private component, we can use it like we want to. No need for a nearestOfType dependency, probably.
There was a problem hiding this comment.
We use dialogComponent in paper-inner-dialog for 4 different things. We could pass it by binding this, we could bind all four things we use, or we can keep what we have. I thought the discussion from tabs was that it was better to connect the two components than to bind a bunch of properties between two components.
There was a problem hiding this comment.
That discussion does not apply for private components.
We had to resort to such mechanisms because we can't expect the user to pass them by us.
… than use nearestOfType to find the dialog component.
Push paper-dialog forward. Still WIP.
paper-dialog-container.paper-dialog-parent.