Chips: Don't explicitly close autocomplete on inputBlur - fixes #587 #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @miguelcobain , that is only one of few bug we have found on ember-paper so far . in production. |
…ed-ember-addons#587 Explicitly closing the autocomplete component on inputBlur broke the ability to add custom items to the chips element (assuming requireMatch is not true). It doesn't appear to be necessary for any other purpose.
|
Rebased - merging #615 caused a minor conflict. |
|
The Travis failures are on ember-beta and ember-canary, and are unrelated to this change (see #747 for another PR which exhibits those same failures). |
Closed
|
Sorry for taking ridiculously long to merge this quick awesome fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly closing the autocomplete component on inputBlur broke the ability to add custom items to the chips element (assuming requireMatch is not true). It doesn't appear to be necessary for any other purpose.