fix(...) input validations #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xomaczar
commented
Jul 16, 2018
xomaczar
commented
- For paper-input, validate only when its value changes.
- For paper-autocomplete, validate only when selection is changed.
xomaczar
force-pushed
the
fix/input-validation
branch
from
ce63371 to
1340a0c
Compare
1. For paper-input, validate only when value changes 2. For paper-autocomplete, validate when selection is made.
xomaczar
force-pushed
the
fix/input-validation
branch
from
1340a0c to
21de17c
Compare
| @@ -110,7 +110,8 @@ module('Integration | Component | paper form', function(hooks) { | |||
| assert.notOk(isInvalidAndTouched); | |||
| }); | |||
|
|
|||
| this.$('input:first').trigger('blur'); | |||
| await click('input:first-of-type'); | |||
There was a problem hiding this comment.
Why did you change to a click + blur?
There was a problem hiding this comment.
I was changing the underlying code and left this in by mistake - I’ll go back and change it back to blur from test-helpers.
Although, not sure how blur can happen w/o first focus in event
There was a problem hiding this comment.
@xomaczar just asked because there could be some reason I was missing.
|
@xomaczar this looks great. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.