Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ripple touch events passive #964

Conversation

xomaczar
Copy link
Contributor

Improves scrolling and fixes warnings

@Subtletree
Copy link
Collaborator

Subtletree commented Jul 24, 2018

closes #870, maybe closes #843

Good catch with the feature detection 👍. Looks like we might need:

let options = supportsPassiveEventListeners ? { passive: true } : false;

instead of the empty object https://github.com/WICG/EventListenerOptions/blob/gh-pages/explainer.md#feature-detection

Could add the same treatment to the paper-tooltip listener too

@xomaczar xomaczar force-pushed the feat/passive-events-listeners branch from 524b6fb to 49e764e Compare July 24, 2018 04:10
@xomaczar
Copy link
Contributor Author

xomaczar commented Jul 24, 2018

@Subtletree thanks for the code review, sorry I did not see that there was an open PR handling similar use case already. I've updated my PR with your suggestions.

@xomaczar
Copy link
Contributor Author

^ @miguelcobain

@miguelcobain
Copy link
Collaborator

Indeed, the feature detection is needed to correctly use passive events.
Thank you both @xomaczar and @Subtletree.

@miguelcobain miguelcobain merged commit 141fdee into adopted-ember-addons:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants