Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reference SwiftGodot using .package(url: … from: 0.21.0 #175

Closed
PadraigK opened this issue Oct 15, 2023 · 3 comments
Closed

Can't reference SwiftGodot using .package(url: … from: 0.21.0 #175

PadraigK opened this issue Oct 15, 2023 · 3 comments

Comments

@PadraigK
Copy link
Contributor

If I add SwiftGodot as a dependency pointing to branch: "main" everything works, but if I use the .package(url: "https://github.com/migueldeicaza/SwiftGodot", from: "0.21.0") syntax, then swift package update fails with:

> error: the target 'SwiftGodot' in product 'SwiftGodot' contains unsafe build flags

I reviewed the commits between the 0.21.0 tag and main and they do not change anything in the Package file. I looked into it and it turns out that Swift PM handles these two differently.

This means that we will either need to get rid of the unsafe flags in the Swift Godot package, or we will not be able to use release tags.


The unsafe flags, for reference:

.unsafeFlags([
    "-Xlinker", "-undefined",
    "-Xlinker", "dynamic_lookup",
])
@alicerunsonfedora
Copy link
Contributor

I've been running into this as well, and I believe I documented it in an earlier issue (#52, I think?). A workaround I've been using is referencing the commit hash of the tag in question, rather than the tag itself

@PadraigK
Copy link
Contributor Author

Right, that works, but we ideally ought to have standard release conventions, so I think it's important to figure this out.

@migueldeicaza
Copy link
Owner

This is tentatively working now with the suggested approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants