Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsafeFlags from Package.swift #177

Closed

Conversation

PadraigK
Copy link
Contributor

I removed this locally and did some testing — everything seems fine without it.

Fixes #175

@PadraigK
Copy link
Contributor Author

My formatter ran on the Package.swift so the diff is bigger than it should be. The interesting changes here are:

90d3910

@migueldeicaza
Copy link
Owner

Ok, I am a little nervous because I do not recall the reason for this dynamic_lookup change.

So what I am going to do is commit the change, but leave the original stuff commented out, so if we find some odd breakage, we know what to fix.

If there is no breakages in a couple of week, we wipe it out.

@migueldeicaza
Copy link
Owner

Ok, applied the patch manually as a comment instead, and updated the docs.

@PadraigK
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't reference SwiftGodot using .package(url: … from: 0.21.0
2 participants