Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crashing on windows when picking a directory #1340

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Fixed crashing on windows when picking a directory #1340

merged 3 commits into from
Aug 25, 2023

Conversation

kirill-21
Copy link
Contributor

Fixed crash when picking a directory. [https://github.com/https://github.com//issues/1317, https://github.com/https://github.com//issues/1297]

"Note that, with v5.0.0, .release() is also called automatically if you wish to upgrade it." https://win32.pub/docs/com-programming/basics#releasing-com-objects

@kirill-21
Copy link
Contributor Author

@miguelpruivo can you please merge it?

@miguelpruivo miguelpruivo merged commit 316e9d3 into miguelpruivo:master Aug 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants