Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #1430

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Minor fixes #1430

merged 3 commits into from
Mar 4, 2024

Conversation

tvolkert
Copy link

@tvolkert tvolkert commented Jan 8, 2024

  • Allow m4v files in FileType.media filter
  • throw if caller tries to use allowedExtensiosn with any file type other than custom

* Allow m4v files in FileType.media filter
* throw if caller tries to use allowedExtensiosn with any file
  type other than custom
lib/src/file_picker_macos.dart Outdated Show resolved Hide resolved
@navaronbracke
Copy link
Collaborator

navaronbracke commented Jan 9, 2024

We have one test that is failing, because the expectation needs to be updated.

flutter_file_picker/flutter_file_picker/test/file_picker_macos_test.dart: fileTypeToFileFilter() should return the file filter (failed)
  Expected: '"avi", "flv", "mkv", "mov", "mp4", "mpeg", "webm", "wmv", "bmp", "gif", "jpeg", "jpg", "png"'
    Actual: '"avi", "flv", "m4v", "mkv", "mov", "mp4", "mpeg", "webm", "wmv", "bmp", "gif", "jpeg", "jpg", "png"'
     Which: is different.
            Expected: ...  "flv", "mkv", "mov" ...
              Actual: ...  "flv", "m4v", "mkv" ...
                                    ^
             Differ at offset [16](https://github.com/miguelpruivo/flutter_file_picker/actions/runs/7456317251/job/20290515807?pr=1430#step:8:17)

And while I'm talking about tests, could you perhaps add a test for the ArgumentError as well? (one for file_picker_io and one for file_picker_macos)

Copy link
Owner

@miguelpruivo miguelpruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@miguelpruivo miguelpruivo merged commit d6f1314 into miguelpruivo:master Mar 4, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants