Fix Issue 1505(Fix cache delete) #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
navaronbracke
requested changes
Aug 15, 2024
| @@ -471,4 +465,18 @@ private static String getDocumentPathFromTreeUri(final Uri treeUri) { | |||
| else return File.separator; | |||
| } | |||
|
|
|||
| private static void recursiveDeleteFile(final File file) throws Exception { | |||
| if (!file.exists()) { | |||
There was a problem hiding this comment.
The old code had a null check on the file too. Perhaps add that here as well?
There was a problem hiding this comment.
@navaronbracke Thanks, I fixed. 375a10a
|
The version & changelog also needs to be updated. |
navaronbracke
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1505
implement recursive delete file.
because, Java cannot delete not-empty directory.