Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a single image from Google Photos does not work #58 #59

Closed
wants to merge 1 commit into from

Conversation

Boehrsi
Copy link

@Boehrsi Boehrsi commented Mar 21, 2019

Fix for #58

I just added a small check if isMultipleSelection and "map" the list to a String if not.

@miguelpruivo
Copy link
Owner

This is should be protected in the Android side like is being already done in iOS whereas a single String is being returned if the list contains only one item.

@Boehrsi
Copy link
Author

Boehrsi commented Mar 21, 2019

This is should be protected in the Android side like is being already done in iOS whereas a single String is being returned if the list contains only one item.

Yep would also work for that case 👍

@miguelpruivo
Copy link
Owner

This has now been fixed in 1.3.3 by protecting in the Android native callback so this PR is not longer required.

Anyhow, thank you for contributing.

@Boehrsi Boehrsi deleted the issue-58 branch January 16, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants