-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Wildcards for files association #101
Feat: Wildcards for files association #101
Conversation
@@ -9,7 +9,12 @@ const updateThemeJSONHandlers = { | |||
}, | |||
"files.associations": (themeJSON, files) => { | |||
for (const file in files) { | |||
themeJSON.fileNames[file] = files[file]; | |||
if(file.startsWith('*.')){ | |||
const newExtension = file.replace('*.',''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const newExtension = file.replace('*.',''); | |
const newExtension = file.substring(2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wladimirgrf This is working lovely! One minor question, should we also support ".service.ts": "angular"
without the *
, to ensure it works multiple ways?
@miguelsolorio No, we need to have a character, in this case If we only consider the Because for cases like |
Ah, that makes sense! In that case let's merge this in. Thanks again! 🍻 |
This Pull Request introduces a new feature, wildcards for file customization.
Solving this issue: Allow wildcards in files association #93
Example: