Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: console spam #108

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix: console spam #108

merged 1 commit into from
Aug 4, 2023

Conversation

luxass
Copy link
Contributor

@luxass luxass commented Jul 10, 2023

This PR fixes the spam in console, by extracting it to an OutputChannel
image

image

miguelsolorio
miguelsolorio approved these changes Aug 4, 2023
View reviewed changes
Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👏

@miguelsolorio miguelsolorio self-requested a review August 4, 2023 18:23
@miguelsolorio miguelsolorio added this to the 0.0.13 milestone Aug 4, 2023
@miguelsolorio miguelsolorio merged commit cf380f2 into miguelsolorio:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsolorio miguelsolorio Awaiting requested review from miguelsolorio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.14
Development

Successfully merging this pull request may close these issues.
2 participants
@luxass @miguelsolorio