Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon for CUDA files #218

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Add icon for CUDA files #218

merged 4 commits into from
Sep 4, 2024

Conversation

eduardo-kurek
Copy link
Contributor

cuda

@miguelsolorio
Copy link
Owner

Thanks for the PR, but this one is hard to read when small. Would you mind doing someting simple like using the nvidia logo?

CleanShot 2024-08-04 at 22 46 54@2x

@eduardo-kurek
Copy link
Contributor Author

I thought doing this way for being similar to C and C++, but i agree with you, it is small. I already made the changes:

image

@miguelsolorio miguelsolorio self-assigned this Sep 4, 2024
@miguelsolorio miguelsolorio added this to the 0.0.19 milestone Sep 4, 2024
miguelsolorio
miguelsolorio approved these changes Sep 4, 2024
View reviewed changes
Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixed the iconDefinition file path

@miguelsolorio miguelsolorio merged commit 30fb1fe into miguelsolorio:main Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsolorio miguelsolorio miguelsolorio approved these changes

Assignees

@miguelsolorio miguelsolorio

Labels
None yet
Projects
None yet
Milestone
0.0.19
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardo-kurek @miguelsolorio