Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon/folder-icon for Gitlab #230

Closed
wants to merge 3 commits into from

Conversation

dimentoree
Copy link
Contributor

Add icon and folder-icon for GitLab files

изображение
изображение

@miguelsolorio
Copy link
Owner

@dimentoree had to fix the icon size because it was too large, also what is the file name for a gitlab issue? Can't seem to find any info on .gitlab-issues

CleanShot 2024-09-03 at 22 56 48@2x

@dimentoree
Copy link
Contributor Author

@dimentoree had to fix the icon size because it was too large, also what is the file name for a gitlab issue? Can't seem to find any info on .gitlab-issues

CleanShot 2024-09-03 at 22 56 48@2x

Hi, regarding the file name .gitlab-issues - I specified it at first by analogy with git, but when I started checking what file types are used with gitlab, I didn't find one and probably forgot to remove it. I'll be more careful in the future, thanks

miguelsolorio added a commit that referenced this pull request Sep 4, 2024
@miguelsolorio
Copy link
Owner

miguelsolorio commented Sep 4, 2024

This PR was a little gnarly with the previous commits, so I had to add this separately in 25b8199 I'll still credit you in the release notes

@miguelsolorio miguelsolorio self-assigned this Sep 4, 2024
@miguelsolorio miguelsolorio added this to the 0.0.19 milestone Sep 4, 2024
@dimentoree
Copy link
Contributor Author

This PR was a little gnarly with the previous commits, so I had to add this separately in 25b8199 I'll still credit you in the release notes

Thank you very much)

@dimentoree dimentoree deleted the add-gitlab-icons branch September 5, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants