Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rstack family icon #236

Merged
merged 3 commits into from
Sep 4, 2024
Merged

add rstack family icon #236

merged 3 commits into from
Sep 4, 2024

Conversation

wChenonly
Copy link
Contributor

@wChenonly wChenonly commented Sep 4, 2024 •
edited
Loading

Added product diagrams for the rstack family

rstack icon resources

Here's the demo

rspack-demo rslib-demo rsbuild-demo heji image

@miguelsolorio miguelsolorio self-assigned this Sep 4, 2024
@miguelsolorio miguelsolorio added the icon request Request for a new icon label Sep 4, 2024
@miguelsolorio miguelsolorio added this to the 0.0.19 milestone Sep 4, 2024
miguelsolorio
miguelsolorio approved these changes Sep 4, 2024
View reviewed changes
Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🫶

@miguelsolorio miguelsolorio merged commit b448b84 into miguelsolorio:main Sep 4, 2024
1 check passed
@wChenonly wChenonly mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsolorio miguelsolorio miguelsolorio approved these changes

Assignees

@miguelsolorio miguelsolorio

Labels
icon request Request for a new icon
Projects
None yet
Milestone
0.0.19
Development

Successfully merging this pull request may close these issues.
2 participants
@wChenonly @miguelsolorio