Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in interface icon #242

Closed
wants to merge 1 commit into from

Conversation

nikolailehbrink
Copy link

No description provided.

@miguelsolorio
Copy link
Owner

@nikolailehbrink thanks for the PR, a few things:

  1. Looks like you've also got Rename folder-intefaces.png to folder-interfaces.png #243, please consolidate these PRs
  2. Include a screenshot of the extension with your changes
  3. If you are going to rename this you will need to add the old name as well so as to not break existing usage

@nikolailehbrink
Copy link
Author

Hi @miguelsolorio, was doing it quickly in GitHub, that's why these are separate. Wanted to make you aware of the mistake, but I have not planned on further working on this MR. Thanks for the package!

@miguelsolorio
Copy link
Owner

@nikolailehbrink so you don't plan on updating this PR? If you were just wanting to notify of the bug you can just create a regular issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants