Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Toggle Explorer Arrows Configuration #8

Merged
merged 10 commits into from
Aug 14, 2022

Conversation

barelyhuman
Copy link
Contributor

@barelyhuman barelyhuman commented Aug 12, 2022

  • register command to handle arrow toggling, removed since it adds a lot of complexity to a simple change which can be a lot easily handled by just changing the configuration
  • split up into maintainable modules
  • move .json to .default.json for the default settings and generate a new .json from it when the theme is first activated , added an ignored file .modified.json that vscode will look for so the source stays as is
  • add a listener for configuration changes to make this portable

Adds to the vscode configuration

"symbols.hidesExplorerArrows":true

fixes the json format to be made parseable by the default spec
adds in a command and it's respective function for over-riding the json
helpers and implementation of a
configuration monitor for the keys defined in
package.json
@barelyhuman barelyhuman marked this pull request as ready for review August 13, 2022 08:24
@barelyhuman
Copy link
Contributor Author

barelyhuman commented Aug 13, 2022

The force-push only edits one commit 0c6c832, since changes were added to main yesterday that weren't in the fork and the mentioned commit removed trailing commas in the JSON

Hope that's fine :)

@barelyhuman barelyhuman changed the title Feature: Toggle Explorer Arrows Command and Configuration Feature: Toggle Explorer Arrows Configuration Aug 13, 2022
Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge PR, thank you so much for tackling this! Made some minor changes and show a notification when the change has been made to ask users to reload.

EDIT: Ended up removing the notification as it was unnecessary.

@miguelsolorio
Copy link
Owner

@barelyhuman one issue I am seeing is that if symbol-icon-theme.modified.json already exists, when you make changes to symbol-icon-theme.json the modified file does not get updated. It's almost like we need to do cleanup when activating the extension. Would you be able to add this?

@barelyhuman
Copy link
Contributor Author

i guess I totally forgot about handling updates in the theme, will add a sync on activation to check for new props.

Should be able to raise a PR around noon tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants