Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Option to Copy Panel to Clipboard #1003

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

Animeboynz
Copy link
Contributor

Uses Android's ClipboardManager to copy an Panel to the clipboard.

@Animeboynz
Copy link
Contributor Author

Damb you Build Checks.

@Animeboynz
Copy link
Contributor Author

Well finally down to one issue and its one I'm definitely not going to attempt as I'll probably break the entire thing xD

/home/runner/work/mihon/mihon/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt:84:7: Class ReaderViewModel is too large. Consider splitting it into smaller pieces. [LargeClass]

@Animeboynz
Copy link
Contributor Author

Animeboynz commented Jul 12, 2024

@AntsyLich This is basically done from my end, just let me know if you need me to remove the UI or if there is anything else you need me to do

@AntsyLich
Copy link
Member

Rebase and fix build thanks

Copy link
Member

@AntsyLich AntsyLich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do a rebase instead of merging. It's a total mess

@Animeboynz Animeboynz closed this Jul 25, 2024
@Animeboynz Animeboynz force-pushed the Copy-Panel-to-Clipboard branch from 878c4ed to 41e2dc7 Compare July 25, 2024 20:31
@Animeboynz Animeboynz reopened this Jul 25, 2024
@Animeboynz Animeboynz requested a review from AntsyLich July 25, 2024 21:01
Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
@AntsyLich AntsyLich merged commit 0af9099 into mihonapp:main Jul 26, 2024
1 check passed
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Jul 27, 2024
* Add Copy to Clipboard

* Removing Unused Import

* Reusing onShare function

* Commit Suggestion

* Early Return on null

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>

---------

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
(cherry picked from commit 0af9099)
@Animeboynz Animeboynz deleted the Copy-Panel-to-Clipboard branch July 27, 2024 10:13
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Jul 30, 2024
* Add Copy to Clipboard

* Removing Unused Import

* Reusing onShare function

* Commit Suggestion

* Early Return on null

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>

---------

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
(cherry picked from commit 0af9099)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants