Add Copy Tracker URL on icon long press #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Catt0s <5874051+mm12@users.noreply.github.com>
|
Re: #1087 (comment), how about adding "Copy to clipboard" to the 3-dot menu too? inb4 Antsy: Switch "Implements" for a supported keyword |
Good idea, I will check into it. In that case, why not also have a copy name item? Or long click the open in browser?
done :) |
Signed-off-by: Catt0s <5874051+mm12@users.noreply.github.com>
|
Replace text with "Copy link"? |
I was looking for text that would better suit it, but "Copy to clipboard" is the closest I could find in the locales texts. Should I just add it into there? |
|
Yeah do that |
Signed-off-by: Catt0s <5874051+mm12@users.noreply.github.com>
AntsyLich
requested changes
Aug 10, 2024
app/src/main/java/eu/kanade/presentation/track/components/TrackLogoIcon.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackInfoDialog.kt
Outdated
Show resolved
Hide resolved
> > Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> Signed-off-by: Catt0s <5874051+mm12@users.noreply.github.com>
AntsyLich
reviewed
Aug 11, 2024
app/src/main/java/eu/kanade/presentation/track/components/TrackLogoIcon.kt
Outdated
Show resolved
Hide resolved
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Aug 12, 2024
* Add Copy Tracker URL on icon long press Signed-off-by: Catt0s <5874051+mm12@users.noreply.github.com> * Add 'Copy To Clipboard' to tracker item menu Signed-off-by: Catt0s <5874051+mm12@users.noreply.github.com> * Add 'Copy link' to locales. Signed-off-by: Catt0s <5874051+mm12@users.noreply.github.com> * Implement code review suggestions > > Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> Signed-off-by: Catt0s <5874051+mm12@users.noreply.github.com> * Update app/src/main/java/eu/kanade/presentation/track/components/TrackLogoIcon.kt --------- Signed-off-by: Catt0s <5874051+mm12@users.noreply.github.com> Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> (cherry picked from commit 200d39e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1087.
When the icon for a tracker is held down, the tracker URL is copied to the clipboard, if it exists.
From @BrutuZ's comment, I have also added it to the menu:
