Add option to skip downloading duplicate read chapters #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…manual manga fetch
shabnix
force-pushed
the
prevent-download-duplicate-chapters
branch
from
fc8ef77 to
3a543c1
Compare
AntsyLich
reviewed
Aug 20, 2024
app/src/main/java/mihon/core/chapters/utils/FilterChaptersToDownload.kt
Outdated
Show resolved
Hide resolved
shabnix
force-pushed
the
prevent-download-duplicate-chapters
branch
from
7c5caa1 to
ac2a778
Compare
AntsyLich
reviewed
Aug 20, 2024
app/src/main/java/eu/kanade/domain/chapter/interactor/SyncChaptersWithSource.kt
Outdated
Show resolved
Hide resolved
shabnix
commented
Aug 20, 2024
app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt
Outdated
Show resolved
Hide resolved
shabnix
force-pushed
the
prevent-download-duplicate-chapters
branch
from
96beb0c to
1a2dce7
Compare
shabnix
force-pushed
the
prevent-download-duplicate-chapters
branch
from
c3baa97 to
35bede5
Compare
|
I am currently unable to test the latest changes, but I will provide an update on it tomorrow. |
AntsyLich
requested changes
Aug 20, 2024
domain/src/main/java/mihon/domain/chapter/interactor/GetChaptersToDownload.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/mihon/domain/chapter/interactor/GetChaptersToDownload.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/tachiyomi/domain/download/service/DownloadPreferences.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDownloadScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDownloadScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt
Outdated
Show resolved
Hide resolved
shabnix
force-pushed
the
prevent-download-duplicate-chapters
branch
from
4426eb6 to
839ad09
Compare
AntsyLich
requested changes
Aug 21, 2024
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
AntsyLich
requested changes
Aug 21, 2024
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
shabnix
force-pushed
the
prevent-download-duplicate-chapters
branch
from
4076b96 to
81193cf
Compare
shabnix
force-pushed
the
prevent-download-duplicate-chapters
branch
2 times, most recently
from
dcf721e to
5e3b91d
Compare
|
run |
AntsyLich
reviewed
Aug 23, 2024
domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt
Outdated
Show resolved
Hide resolved
…ptersForDownload.kt
|
Great work (tho i had to make you change everything with review 🫠) |
AntsyLich
approved these changes
Aug 23, 2024
AntsyLich
changed the title
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Aug 24, 2024
…n#1125) * Add query to get chapter count by manga and chapter number * Add functions to get chapter count by manga and chapter number * Only count read chapters * Add interactor * Savepoint * Extract new chapter logic to separate function * Update javadocs * Add preference to toggle new functionality * Add todo * Add debug logcat * Use string resource instead of hardcoding title * Add temporary logcat for debugging * Fix detekt issues * Update javadocs * Update download unread chapters preference * Remove debug logcat calls * Update javadocs * Resolve issue where read chapters were still being downloaded during manual manga fetch * Apply code review changes * Apply code review changes * Revert "Apply code review changes" This reverts commit 1a2dce78acc66a7c529ce5b572bdaf94804b1a30. * Revert "Apply code review changes" This reverts commit ac2a77829313967ad39ce3cb0c0231083b9d640d. * Group download chapter logic inside the interactor GetChaptersToDownload * Update javadocs * Apply code review * Apply code review * Apply code review * Update CHANGELOG.md to include the new feature * Run spotless * Update domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt --------- Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> (cherry picked from commit ca968f1)
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Aug 24, 2024
…n#1125) * Add query to get chapter count by manga and chapter number * Add functions to get chapter count by manga and chapter number * Only count read chapters * Add interactor * Savepoint * Extract new chapter logic to separate function * Update javadocs * Add preference to toggle new functionality * Add todo * Add debug logcat * Use string resource instead of hardcoding title * Add temporary logcat for debugging * Fix detekt issues * Update javadocs * Update download unread chapters preference * Remove debug logcat calls * Update javadocs * Resolve issue where read chapters were still being downloaded during manual manga fetch * Apply code review changes * Apply code review changes * Revert "Apply code review changes" This reverts commit 1a2dce78acc66a7c529ce5b572bdaf94804b1a30. * Revert "Apply code review changes" This reverts commit ac2a77829313967ad39ce3cb0c0231083b9d640d. * Group download chapter logic inside the interactor GetChaptersToDownload * Update javadocs * Apply code review * Apply code review * Apply code review * Update CHANGELOG.md to include the new feature * Run spotless * Update domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt --------- Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> (cherry picked from commit ca968f1)
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Aug 25, 2024
…n#1125) * Add query to get chapter count by manga and chapter number * Add functions to get chapter count by manga and chapter number * Only count read chapters * Add interactor * Savepoint * Extract new chapter logic to separate function * Update javadocs * Add preference to toggle new functionality * Add todo * Add debug logcat * Use string resource instead of hardcoding title * Add temporary logcat for debugging * Fix detekt issues * Update javadocs * Update download unread chapters preference * Remove debug logcat calls * Update javadocs * Resolve issue where read chapters were still being downloaded during manual manga fetch * Apply code review changes * Apply code review changes * Revert "Apply code review changes" This reverts commit 1a2dce78acc66a7c529ce5b572bdaf94804b1a30. * Revert "Apply code review changes" This reverts commit ac2a77829313967ad39ce3cb0c0231083b9d640d. * Group download chapter logic inside the interactor GetChaptersToDownload * Update javadocs * Apply code review * Apply code review * Apply code review * Update CHANGELOG.md to include the new feature * Run spotless * Update domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt --------- Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> (cherry picked from commit ca968f1)
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Aug 25, 2024
…n#1125) * Add query to get chapter count by manga and chapter number * Add functions to get chapter count by manga and chapter number * Only count read chapters * Add interactor * Savepoint * Extract new chapter logic to separate function * Update javadocs * Add preference to toggle new functionality * Add todo * Add debug logcat * Use string resource instead of hardcoding title * Add temporary logcat for debugging * Fix detekt issues * Update javadocs * Update download unread chapters preference * Remove debug logcat calls * Update javadocs * Resolve issue where read chapters were still being downloaded during manual manga fetch * Apply code review changes * Apply code review changes * Revert "Apply code review changes" This reverts commit 1a2dce78acc66a7c529ce5b572bdaf94804b1a30. * Revert "Apply code review changes" This reverts commit ac2a77829313967ad39ce3cb0c0231083b9d640d. * Group download chapter logic inside the interactor GetChaptersToDownload * Update javadocs * Apply code review * Apply code review * Apply code review * Update CHANGELOG.md to include the new feature * Run spotless * Update domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt --------- Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> (cherry picked from commit ca968f1)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some sources provide multiple scanlations for the same chapter, which can result in certain scanlators being ahead of others, and official releases often lagging behind. The current automatic download system downloads new chapters regardless of whether the same chapter has already been read from a different scanlator. This causes unnecessary downloads of already read content, increasing the load on sources and wasting storage space.
Change Introduced
This pull request introduces an option to prevent the downloading of chapters that have already been read. This functionality is enabled by default when the "download new chapters" setting is enabled, but it can be disabled.