-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to update trackers when chapter marked as read #1177
Merged
AntsyLich
merged 10 commits into
mihonapp:main
from
Animeboynz:Track-When-Marked-as-Read
Sep 2, 2024
Merged
Option to update trackers when chapter marked as read #1177
AntsyLich
merged 10 commits into
mihonapp:main
from
Animeboynz:Track-When-Marked-as-Read
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntsyLich
reviewed
Aug 29, 2024
app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
Outdated
Show resolved
Hide resolved
AntsyLich
reviewed
Aug 30, 2024
app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
Outdated
Show resolved
Hide resolved
AntsyLich
reviewed
Aug 30, 2024
app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
Outdated
Show resolved
Hide resolved
AntsyLich
reviewed
Aug 31, 2024
app/src/main/java/eu/kanade/domain/track/interactor/TrackChapter.kt
Outdated
Show resolved
Hide resolved
AntsyLich
requested changes
Sep 1, 2024
app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
Outdated
Show resolved
Hide resolved
Co-Authored-By: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
AntsyLich
requested changes
Sep 2, 2024
app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
Outdated
Show resolved
Hide resolved
AntsyLich
changed the title
Update trackers when marked as read
Option to update trackers when chapter marked as read
Sep 2, 2024
AntsyLich
approved these changes
Sep 2, 2024
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Sep 4, 2024
…#1177) * Track when marked as read * Add dismiss to snack bar * i18n & ignore decimal chapters * Detekt would have caught that 🤣 * `Ok` > `Yes` * Dont prompt if untracked or current > new * Move to MangaScreenModel * Suggestions Co-Authored-By: AntsyLich <59261191+AntsyLich@users.noreply.github.com> * Review 2 * toggleAllSelections first --------- Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> (cherry picked from commit abfb72c) # Conflicts: # app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows a snack bar to update trackers when you mark chapters as read.
Closes #619
More Context : https://git.mihon.tech/tachiyomi/tachiyomi/issues/389#issuecomment-28053