Added configuration options to e-ink page flashes #625
Conversation
app/src/main/java/eu/kanade/tachiyomi/ui/reader/setting/ReaderPreferences.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/reader/setting/ReaderPreferences.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/reader/setting/ReaderPreferences.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsReaderScreen.kt
Outdated
Show resolved
Hide resolved
There is one outstanding issue that is being discussed, where the state management for the flash interval is currently loaded in a non-reactive way, and thus does not update when set in the reader quick settings sheet |
|
Before this gets merged I'd like to bring up something I just discovered. My Ebook offers a SDK that can be used to properly flash the screen similar to the procedure Kindle devices do. Would it be possible to somehow abstract the flashing logic using an interface? And mihon could then inject different implementations depending on which device it runs on. |
Seems interesting. At a glance, it does appear to be designed for pre-compose android development, so I am not 100% sure how well their refresh hook would work with compose. As mentioned in the initial PR Comment, trying to get this properly supported with the way the current reader is implemented will be a lot more work, think of this PR as a bandage to help out e-ink users, without needing substantial changes at this time. |
Adds some configuration options for the e-ink page flash to better support a variety of devices.
Added Flash duration options - 100-1500ms
Added Flash style options - Black, White, White/Black
Added Flash spacing options - 1 - 10 pages
The current page flash system really is a hack over the reader (adding a colored rectangle over the reader for the duration of the flash) hooked into every page. Trying to use this hook to enable and disable the invert filter had low success, particularly because it only triggers after the page change animation has already started to play. Attempt to add a proper invert or inline screen clear will probably require a refactor for on-exit hooks that can delay a transition, but that seemed beyond the scope of getting this more usable for our e-ink users.
Closes #585