Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storage permission request for non-conforming devices #726

Merged
merged 5 commits into from
Jun 1, 2024
+12 −1
Merged

fix: storage permission request for non-conforming devices #726

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75149c3
fix: storage permission request for non-conforming devices
mainrs Apr 29, 2024
146affe
fix: catch more specific exception
mainrs May 4, 2024
9ff2fae
chore: add toast message to indicate missing persistent permissions
mainrs May 27, 2024
a7603a6
chore: correct newly introduced translaction string
mainrs May 27, 2024
8ece5fe
Change error toast message
AntsyLich Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,16 @@ object SettingsDataScreen : SearchableSettings {
val flags = Intent.FLAG_GRANT_READ_URI_PERMISSION or
Intent.FLAG_GRANT_WRITE_URI_PERMISSION

context.contentResolver.takePersistableUriPermission(uri, flags)
// For some reason InkBook devices do not implement the SAF properly. Persistable URI grants do not
// work. However, simply retrieving the URI and using it works fine for these devices. Access is not
// revoked after the app is closed or the device is restarted.
// This also holds for some Samsung devices. Thus, we simply execute inside of a try-catch block and
// ignore the exception if it is thrown.
try {
context.contentResolver.takePersistableUriPermission(uri, flags)
} catch (e: SecurityException) {
logcat(LogPriority.ERROR, e)
mainrs marked this conversation as resolved.
Show resolved Hide resolved
}

UniFile.fromUri(context, uri)?.let {
storageDirPref.set(it.uri.toString())
Expand Down
Loading