-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NotifySend support for app name #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! Took long to merge this, but looks good to me. |
This was referenced Mar 7, 2021
Closed
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, notify-send has an option to set the app name, but I couldn't be able to pass that option through node-notifier, so I made the additions that enables people to use that option if they want to, using node-notifier.
Although it seems notify-send man page doesn't say anything about this option, it's definitively there, I tested the option under some Ubuntu based systems and notify-send recognizes the option, also you can find information about the option from other sources like this one notify-send options.
One thing this option does is let you change the "notify-send" default app name, that shows in the notification no matter what in some notifications system.
For example, executing
notifier.notify({title: 'Hello Message', message: 'This is a node-notifier message'})
and we get:But after these changes, you can do
notifier.notify({title: 'Hello Message', message: 'This is a node-notifier message', 'app-name': 'node-notifier'})
to get: