Avoid never used call to create empty string #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the function split() will create a vector with a length of at least 1, the case where length equals zero will never happen.
mike-engel
approved these changes
Aug 1, 2023
|
Thanks @peter-scholtens! Just curious, are you using this in embedded devices? You've been working on several optimizations that most computers probably don't need 😄 |
|
I did hardware design in the past (mixed-signal silicon circuit design), so I prefer to make frugal usage of memory size and computation indeed :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the function split() will create a vector with a length of at least 1 (see second example here), the case where length equals zero will never happen. I checked with the compiler explorer and this reduces function new() with 20 machine code instructions.