Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#132 #136 C++ port light refactororing and bug fix #140

Merged
merged 14 commits into from
Aug 1, 2024
Merged

#132 #136 C++ port light refactororing and bug fix #140

merged 14 commits into from
Aug 1, 2024

Conversation

vityaman
Copy link
Contributor

@vityaman vityaman commented Jul 31, 2024 •
edited
Loading

@vityaman vityaman force-pushed the 132-port-cpp-refactor branch 3 times, most recently from a2bf98e to 8a1ed14 Compare July 31, 2024 15:58
@vityaman vityaman marked this pull request as ready for review July 31, 2024 16:10
@vityaman
Copy link
Contributor Author

vityaman commented Jul 31, 2024 •
edited
Loading

Release

10/12 Test #10: CPP14Parser.SimpleExample .....................................................   Passed    0.06 sec
      Start 11: CPP14Parser.SimpleCppExampleWithErrorsInInput
11/12 Test #11: CPP14Parser.SimpleCppExampleWithErrorsInInput .................................   Passed    0.05 sec

Comparing to

      Start  9: CPP14Parser.SimpleExample
 9/11 Test  #9: CPP14Parser.SimpleExample .....................................................   Passed    0.10 sec
      Start 10: CPP14Parser.SimpleCppExampleWithErrorsInInput
10/11 Test #10: CPP14Parser.SimpleCppExampleWithErrorsInInput .................................   Passed    0.09 sec

Asan

      Start 10: CPP14Parser.SimpleExample
10/12 Test #10: CPP14Parser.SimpleExample .....................................................   Passed    0.97 sec
      Start 11: CPP14Parser.SimpleCppExampleWithErrorsInInput
11/12 Test #11: CPP14Parser.SimpleCppExampleWithErrorsInInput .................................   Passed    0.81 sec
      Start 12: CPP14Parser.RealCppFile

Comparing to

      Start  9: CPP14Parser.SimpleExample
 9/11 Test  #9: CPP14Parser.SimpleExample .....................................................   Passed    2.29 sec
      Start 10: CPP14Parser.SimpleCppExampleWithErrorsInInput
10/11 Test #10: CPP14Parser.SimpleCppExampleWithErrorsInInput .................................   Passed    2.05 sec

mike-lischke
mike-lischke reviewed Aug 1, 2024
View reviewed changes
ports/cpp/source/antlr4-c3/CodeCompletionCore.hpp Outdated
Comment on lines 8 to 9
#ifndef CODE_COMPLETION_CORE_HPP
#define CODE_COMPLETION_CORE_HPP
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue per se, but why not using pragma once, it's much nicer to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced with pragma once

@vityaman
mike-lischke#132 Configure Clang-Tidy identifier naming
426e4d2 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Make internal types private
81f04fb 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Reduce copy-constructor calls
6ecb2b7 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#136 Fix CppParser::SimpleExample test
80b9e3f 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Use unordered map instead of ordered
8660535 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Store const Token pointers
8cf408d 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Document out of bounds caret behavior
ee978db 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Remove redundant condition
af30224 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Remove redundant variable
695ad15 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Use all_of to reduce duplication
a393a8f 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Refactor all_of-like logic
1f788d9 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Refactor DFS code
bb82cf1 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Use std::ranges::find
86ee323 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@vityaman
mike-lischke#132 Use pragma once
8826edd 
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
@mike-lischke mike-lischke merged commit f3e8999 into mike-lischke:main Aug 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-lischke mike-lischke mike-lischke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vityaman @mike-lischke