Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken std::string assign() #71

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

lglina
Copy link
Contributor

@lglina lglina commented Feb 11, 2022

The data member variable in vector was previously renamed to _data so we could have a data getter function (see f379188 ). Not all references in string were updated, so in some cases we're trying to pass the data function to char_traits copy/move/assign where it expects a char_type* instead, breaking things like std::string assign().

This PR updates all references to data to data_.

@lglina
Copy link
Contributor Author

lglina commented Feb 11, 2022

FYI, this cropped up while trying to compile ArduinoJson.

@mike-matera
Copy link
Owner

Thank you so much!

@mike-matera mike-matera merged commit fafec30 into mike-matera:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants