Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop parsing native object #46

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Stop parsing native object #46

wants to merge 4 commits into from

Conversation

manobi
Copy link

@manobi manobi commented Feb 24, 2012

This still pushing apps to couchdb, but is outputing :

undefined:1

^
SyntaxError: Unexpected token o
at Object.parse (native)

I run tests and nothing broke.

@manobi
Copy link
Author

manobi commented Feb 24, 2012

More tests show that it just happens when the design doc already exist in database. Can another people test if my modifications broke something for you ? Because I don't use the CLI command, I have some automated task in every project making:
var ddoc = {}
couchapp.createApp(ddoc, url, function(app){
couchapp.loadAttachments(app.current, __dirname);
app.push();
});

@mikeal
Copy link
Owner

mikeal commented Mar 14, 2012

there was a bug in request for a few versions that were auto-parsing JSON for every repsonse. that has been fixed, but it may have been the real cause of this bug.

but, we should change couchapp to use the builtin request json functionality rather than doing this decode inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants