Skip to content

Commit

Permalink
Don't set StartStop as required for dryers, dishwashers and washers
Browse files Browse the repository at this point in the history
  • Loading branch information
@Caprico85
Caprico85 committed Mar 12, 2024
1 parent 3ad8e8b commit 40440ae
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
15 changes: 9 additions & 6 deletions devices/device.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3076,8 +3076,9 @@
required_traits = ["onoff"];
break;
case "DISHWASHER": // Dishwasher
recommended_traits = ["onoff", "runcycle"];
required_traits = ["startstop"];
// StartStop is listed as required by Google, but the device also works without it. Therefore, we only list it as recommended.
recommended_traits = ["onoff", "runcycle", "startstop"];
required_traits = [];
break;
case "DOOR": // Door
recommended_traits = ["lockunlock"];
Expand All @@ -3092,8 +3093,9 @@
required_traits = ["openclose"];
break;
case "DRYER": // Dryer
recommended_traits = ["modes", "onoff", "runcycle", "toggles"];
required_traits = ["startstop"];
// StartStop is listed as required by Google, but the device also works without it. Therefore, we only list it as recommended.
recommended_traits = ["modes", "onoff", "runcycle", "toggles", "startstop"];
required_traits = [];
break;
case "FAN": // Fan
recommended_traits = ["fanspeed"];
Expand Down Expand Up @@ -3288,8 +3290,9 @@
required_traits = ["openclose"];
break;
case "WASHER": // Washer
recommended_traits = ["modes", "onoff", "runcycle", "toggles"];
required_traits = ["startstop"];
// StartStop is listed as required by Google, but the device also works without it. Therefore, we only list it as recommended.
recommended_traits = ["modes", "onoff", "runcycle", "toggles", "startstop"];
required_traits = [];
break;
case "WATERHEATER": // Water heater
recommended_traits = ["temperaturecontrol"];
Expand Down
6 changes: 3 additions & 3 deletions devices/device.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ module.exports = function (RED) {
this.trait.onoff = true;
break;
case "DISHWASHER": // Dishwasher
this.trait.startstop = true;
// StartStop is listed as required by Google, but the device also works without it. Therefore, we don't set is as required trait here.
break;
case "DOOR": // Door
this.trait.openclose = true;
Expand All @@ -179,7 +179,7 @@ module.exports = function (RED) {
this.trait.openclose = true;
break;
case "DRYER": // Dryer
this.trait.startstop = true;
// StartStop is listed as required by Google, but the device also works without it. Therefore, we don't set is as required trait here.
break;
case "FAN": // Fan
this.trait.onoff = true;
Expand Down Expand Up @@ -346,7 +346,7 @@ module.exports = function (RED) {
this.trait.openclose = true;
break;
case "WASHER": // Washer
this.trait.startstop = true;
// StartStop is listed as required by Google, but the device also works without it. Therefore, we don't set is as required trait here.
break;
case "WATERHEATER": // Water heater
this.trait.onoff = true;
Expand Down

0 comments on commit 40440ae

Please sign in to comment.