Fix compatability with newer meson #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meson 0.60 and newer are completely unable to build revelation without this fix, due to the deprecation of the positional argument used. It can be removed without any change to the output. This is an upstreaming of the patch required to make this build in gentoo: gentoo/gentoo@3496474 Fixes Issue mikelolasagasti#87
|
Thanks for the PR @jayofdoom |
|
If you'll cut a release of this; I'll do the revbump PR in gentoo so we can drop the patch. Thanks! |
|
I'll try to do a 0.5.5 release tomorrow. |
|
@jayofdoom I released 0.5.5. The new version has a new dep on defusedxml. |
|
Thanks, I'm working on the revbump in gentoo as I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meson 0.60 and newer are completely unable to build revelation without
this fix, due to the deprecation of the positional argument used.
It can be removed without any change to the output.
This is an upstreaming of the patch required to make this build in gentoo:
gentoo/gentoo@3496474
Fixes Issue #87
Screenshots
n/a
Testing strategy
I was unable to build the software without this change. After the change, it loaded and
appeared to work normally.
Type of change