change SupportedFeatures API to a list of subobjects (kubernetes-sigs…

…#3200)
mikemorris · Aug 1, 2024 · e244a1b · e244a1b
1 parent d851c46
commit e244a1b
Show file tree

Hide file tree

Showing 8 changed files with 141 additions and 28 deletions.
diff --git a/apis/applyconfiguration/apis/v1/gatewayclassstatus.go b/apis/applyconfiguration/apis/v1/gatewayclassstatus.go
diff --git a/apis/applyconfiguration/apis/v1/supportedfeature.go b/apis/applyconfiguration/apis/v1/supportedfeature.go
diff --git a/apis/applyconfiguration/internal/internal.go b/apis/applyconfiguration/internal/internal.go
diff --git a/apis/applyconfiguration/utils.go b/apis/applyconfiguration/utils.go
diff --git a/apis/v1/gatewayclass_types.go b/apis/v1/gatewayclass_types.go
@@ -261,9 +261,10 @@ type GatewayClassStatus struct {
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 
 	// SupportedFeatures is the set of features the GatewayClass support.
-	// It MUST be sorted in ascending alphabetical order.
+	// It MUST be sorted in ascending alphabetical order by the Name key.
 	// +optional
-	// +listType=set
+	// +listType=map
+	// +listMapKey=name
 	// <gateway:experimental>
 	// +kubebuilder:validation:MaxItems=64
 	SupportedFeatures []SupportedFeature `json:"supportedFeatures,omitempty"`
@@ -278,6 +279,10 @@ type GatewayClassList struct {
 	Items           []GatewayClass `json:"items"`
 }
 
-// SupportedFeature is used to describe distinct features that are covered by
+// FeatureName is used to describe distinct features that are covered by
 // conformance tests.
-type SupportedFeature string
+type FeatureName string
+
+type SupportedFeature struct {
+	Name FeatureName `json:"name"`
+}
diff --git a/apis/v1/zz_generated.deepcopy.go b/apis/v1/zz_generated.deepcopy.go
diff --git a/config/crd/experimental/gateway.networking.k8s.io_gatewayclasses.yaml b/config/crd/experimental/gateway.networking.k8s.io_gatewayclasses.yaml
diff --git a/pkg/generated/openapi/zz_generated.openapi.go b/pkg/generated/openapi/zz_generated.openapi.go