Introduce fetchViaCommits configuration | Offers a new feature to solve an edge case resulting in old PRs not being included in changelog for squash merges
#1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mikepenz
commented
Jul 28, 2023
•
mikepenz
commented
- honor authorDate and commitDate seperatly when detecting the PR date range to consider
- use the right commit for from date
- introduce new getForCommitHash to retrieve PRs based on hashes
- reorganize pull request filtering -> if we get PRs from commit hash, open PRs are already included, neither filtering is
- significantly simplify logic for results from commit hashes (only deduping needed) + filter if we don't want open PRs
- introduce new configuration fetchViaCommits which is best suited for environments with shorter diffs and/or squash merging (1 api request per commit)
- update tests for new configuration option
- FIX #1176 - honor authorDate and commitDate seperatly when detecting the PR date range to consider
- reorganize pull request filtering -> if we get PRs from commit hash, open PRs are already included, neither filtering is needed - significantly simplify logic for results from commit hashes (only deduping needed) + filter if we don't want open PRs
…for environments with shorter diffs and/or squash merging (1 api request per commit)
mikepenz
changed the title
fetchViaCommits configuration | Offers a new feature to solve an edge case resulting in old PRs not being included in changelog for squash merges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.